Repository navigation
chore(deps): pin tzdata in the dev dependencies so legacy zone aliases resolve on ubuntu-26.04 runners - #1890
Conversation
…s resolve on ubuntu-26.04 runners GitHub's ubuntu-latest moved to ubuntu-26.04, whose system zone database drops the legacy links (US/Pacific, PST8PDT). zoneinfo then raises for them, so tests/test_reporting_period_date.py::test_legacy_zone_aliases_resolve_to_the_canonical_date fails on every 9.x run. Pin tzdata 2026.6 in the dev extra and the dev group, as next already does, so zoneinfo falls back to the IANA package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean dev-only dependency pin.
This PR adds tzdata==2026.6 to both the dev extra (pyproject.toml:12) and the dev dependency group (pyproject.toml:20), mirroring the next repo (6cd343f). It restores test_reporting_period_date.py after ubuntu-26.04 runners dropped legacy zone links (US/Pacific, PST8PDT), letting zoneinfo fall back to the IANA tzdata package.
Scope: dev-only, no runtime, public-surface, or wire impact. The chore(deps): prefix is correct, and the exact pin matches the repo's exact-pin convention for dev tooling. No public adcp.* export changes, no generated-code edits, no CI-gate weakening.
Decision path: no critical/high/medium findings (rows 1, 4–8 do not fire). gated_paths is false, so row 2 does not apply despite review_decision: REVIEW_REQUIRED. high_risk is false (rows 3, 5 N/A). No no-auto-approve team match (row 7 N/A). No prior decision. Falls through to row 9 → approve.
Why
GitHub's
ubuntu-latestrunners moved from 24.04 to ubuntu-26.04. That image's system zone database drops the legacy links (US/Pacific,PST8PDT).zoneinfo.ZoneInforaises for them, so this test now fails on every 9.x run:tests/test_reporting_period_date.py::test_legacy_zone_aliases_resolve_to_the_canonical_date(ValueError: source_timezone must be an IANA timezone)main's last green run, at 3ede780, used ubuntu-24.04. #1889's runs on ubuntu-26.04 fail only this test.nextpasses on the same image because its dev extras already pintzdata==2026.6, which arrived with 6cd343f.Change
Pin
tzdata==2026.6in thedevextra and thedevdependency group, mirroringnext.zoneinfofalls back to the IANA package when the OS database lacks a zone.uv.lockis gitignored, sopyproject.tomlis the only file changed. This is a dev-only dependency with no runtime or release-note impact.Verification
With zoneinfo forced off the system database (
PYTHONTZPATH=/nonexistent):tzdata: the legacy-alias test fails, which reproduces CI;tests/test_reporting_period_date.pypasses 68/68.Unblocks #1889 and release PR #1862 on the new runners.
🤖 Generated with Claude Code